Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 1004353006: Allow "dynamic" as a constant value in analyzer. (Closed)

Created:
5 years, 9 months ago by Paul Berry
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Allow "dynamic" as a constant value in analyzer. BUG=dartbug.com/22989 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=44723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -14 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 5 chunks +29 lines, -13 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download
A tests/language/const_dynamic_type_literal_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 9 months ago (2015-03-26 21:21:06 UTC) #2
Brian Wilkerson
LGTM
5 years, 9 months ago (2015-03-26 21:24:51 UTC) #3
Paul Berry
5 years, 9 months ago (2015-03-26 21:50:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44723 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698