Use a pool to restrict access to file descriptors in pub.

Use a pool to restrict access to file descriptors in pub.

This is like r30830, but it doesn't check out resources for process invocations
in an attempt to narrow down the cause of the Windows buildbot failure.

This also adds additional logging for the same purpose.

R=rnystrom@google.com
TBR

Committed: https://code.google.com/p/dart/source/detail?r=30839

[nweiz, 2013-12-04 00:49:59]

Committed patchset #1 manually as r30839 (presubmit successful).

[Bob Nystrom, 2013-12-04 00:58:17]

A few suggestions then LGTM.

https://codereview.chromium.org/100393010/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/100393010/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/io.dart:709: "$exitCode.");
Make this one line again.

https://codereview.chromium.org/100393010/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/io.dart:733: readBinaryFile(dataFile);
Instead of reading the whole file, how about just opening and closing it?

Also, add a TODO to remove this.

[nweiz, 2013-12-04 01:21:00]

Rolling code review changes into the next CL.

https://codereview.chromium.org/100393010/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/100393010/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/io.dart:709: "$exitCode.");
On 2013/12/04 00:58:18, Bob Nystrom wrote:
> Make this one line again.

Done.

https://codereview.chromium.org/100393010/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/io.dart:733: readBinaryFile(dataFile);
On 2013/12/04 00:58:18, Bob Nystrom wrote:
> Instead of reading the whole file, how about just opening and closing it?

I want the logs to indicate how big it was as well.

> Also, add a TODO to remove this.

Done.