Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1002713003: completions in map literals (Closed)

Created:
5 years, 9 months ago by danrubel
Modified:
5 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

completions in map literals BUG=dartbug.com/22784 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44432

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : merge cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -17 lines) Patch
M pkg/analysis_server/lib/src/services/completion/optype.dart View 1 3 chunks +8 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_target_test.dart View 2 4 chunks +34 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +88 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 9 months ago (2015-03-12 14:49:33 UTC) #2
scheglov
LGTM
5 years, 9 months ago (2015-03-12 15:12:56 UTC) #3
danrubel
5 years, 9 months ago (2015-03-12 15:25:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 44432 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698