Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1002213002: dart2js: Split the SimplifyInterceptors pass out from the list of optimization passes. (Closed)

Created:
5 years, 9 months ago by Kevin Millikin (Google)
Modified:
5 years, 9 months ago
Reviewers:
floitsch, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Split the SimplifyInterceptors pass out from the list of optimization passes. The backend code generator assumes that SimplifyInterceptors is alwyas run, otherwise it will crash. Split it out from the list of optimizations to make it more clear that it should not be disabled. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=44501

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M pkg/compiler/lib/src/ssa/optimize.dart View 3 chunks +26 lines, -23 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Kevin Millikin (Google)
https://codereview.chromium.org/1002213002/diff/1/pkg/compiler/lib/src/ssa/optimize.dart File pkg/compiler/lib/src/ssa/optimize.dart (right): https://codereview.chromium.org/1002213002/diff/1/pkg/compiler/lib/src/ssa/optimize.dart#newcode71 pkg/compiler/lib/src/ssa/optimize.dart:71: // assumes it is always performed. If this refactoring ...
5 years, 9 months ago (2015-03-13 10:18:04 UTC) #2
sra1
lgtm
5 years, 9 months ago (2015-03-13 12:34:09 UTC) #3
Kevin Millikin (Google)
5 years, 9 months ago (2015-03-16 10:11:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44501 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698