Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1001983003: Added --examine to produce analysis of IDL files (Closed)

Created:
5 years, 9 months ago by terry
Modified:
5 years, 9 months ago
Reviewers:
vsm, Alan Knight
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed is_dictionary to check_dictionaries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -7 lines) Patch
M tools/dom/scripts/dartdomgenerator.py View 2 chunks +4 lines, -1 line 0 comments Download
M tools/dom/scripts/database.py View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/dom/scripts/databasebuilder.py View 1 2 chunks +218 lines, -0 lines 0 comments Download
M tools/dom/scripts/fremontcutbuilder.py View 4 chunks +8 lines, -6 lines 0 comments Download
M tools/dom/scripts/idlnode.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
terry
5 years, 9 months ago (2015-03-12 18:59:29 UTC) #2
vsm
lgtm https://codereview.chromium.org/1001983003/diff/1/tools/dom/scripts/databasebuilder.py File tools/dom/scripts/databasebuilder.py (right): https://codereview.chromium.org/1001983003/diff/1/tools/dom/scripts/databasebuilder.py#newcode800 tools/dom/scripts/databasebuilder.py:800: self._constructors(interface, is_dictionary=False) Just a nit - I find ...
5 years, 9 months ago (2015-03-13 14:58:11 UTC) #3
terry
https://codereview.chromium.org/1001983003/diff/1/tools/dom/scripts/databasebuilder.py File tools/dom/scripts/databasebuilder.py (right): https://codereview.chromium.org/1001983003/diff/1/tools/dom/scripts/databasebuilder.py#newcode800 tools/dom/scripts/databasebuilder.py:800: self._constructors(interface, is_dictionary=False) On 2015/03/13 14:58:11, vsm wrote: > Just ...
5 years, 9 months ago (2015-03-13 15:53:31 UTC) #4
terry
5 years, 9 months ago (2015-03-13 15:54:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 44467 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698