Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1001863003: Update SemanticVisitor with visitIndex, visitSuperIndex (Closed)

Created:
5 years, 9 months ago by Johnni Winther
Modified:
5 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, Anders Johnsen
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Update SemanticVisitor with visitIndex, visitSuperIndex ... and add mixins in preparation for IrBuilder implementation based in SemanticVisitor. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=44595

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Update analyze_unused_dart2js_test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1421 lines, -217 lines) Patch
M pkg/compiler/lib/src/resolution/operators.dart View 2 chunks +10 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 18 chunks +45 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 42 chunks +1240 lines, -145 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 3 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 4 chunks +46 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 11 chunks +75 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 9 months ago (2015-03-12 13:32:04 UTC) #2
Johnni Winther
5 years, 9 months ago (2015-03-13 10:41:35 UTC) #3
karlklose
LGTM.
5 years, 9 months ago (2015-03-19 12:22:10 UTC) #4
Johnni Winther
5 years, 9 months ago (2015-03-20 08:52:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 44595 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698