Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1001863002: Fix DoubleLinkedQueue so that appending to entries also update the queue length. (Closed)

Created:
5 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix DoubleLinkedQueue so that appending to entries also update the queue length. The extra non-queue features of this class are probably unnecessary, and are not proper naming (some functions should be getters). Keeping unchanged for backwards compatibility, but it should probably either be removed or be suitably updated for 2.0. BUG= http://dartbug.com/22802 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=44451

Patch Set 1 #

Patch Set 2 : COmments #

Patch Set 3 : Fix type warnings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -69 lines) Patch
M sdk/lib/collection/queue.dart View 1 2 9 chunks +145 lines, -68 lines 0 comments Download
M tests/corelib/queue_test.dart View 1 2 2 chunks +57 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
5 years, 9 months ago (2015-03-12 14:05:52 UTC) #2
Søren Gjesse
lgtm
5 years, 9 months ago (2015-03-13 07:44:25 UTC) #3
Lasse Reichstein Nielsen
5 years, 9 months ago (2015-03-13 09:41:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 44451 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698