Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1001793002: dart2js: Add support for do/while loops to the CPS backend. (Closed)

Created:
5 years, 9 months ago by Kevin Millikin (Google)
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Add support for do/while loops to the CPS backend. Do/while loops are simpler than for loops, but more complicated than while loops. Add support for them to the CPS translation. BUG= R=johnniwinther@google.com, karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=44450

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorportate review comment.s #

Patch Set 3 : Rebased to svn HEAD. #

Patch Set 4 : Ummm, semicolon? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -13 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 2 chunks +124 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Kevin Millikin (Google)
5 years, 9 months ago (2015-03-12 09:34:20 UTC) #2
karlklose
LGTM. Could you add a test?
5 years, 9 months ago (2015-03-12 12:20:21 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/1001793002/diff/1/pkg/compiler/lib/src/dart_backend/backend.dart File pkg/compiler/lib/src/dart_backend/backend.dart (right): https://codereview.chromium.org/1001793002/diff/1/pkg/compiler/lib/src/dart_backend/backend.dart#newcode163 pkg/compiler/lib/src/dart_backend/backend.dart:163: context.constantSystem, Indent by 4 or align with `context.dartType`.
5 years, 9 months ago (2015-03-12 12:38:07 UTC) #4
Kevin Millikin (Google)
https://codereview.chromium.org/1001793002/diff/1/pkg/compiler/lib/src/dart_backend/backend.dart File pkg/compiler/lib/src/dart_backend/backend.dart (right): https://codereview.chromium.org/1001793002/diff/1/pkg/compiler/lib/src/dart_backend/backend.dart#newcode163 pkg/compiler/lib/src/dart_backend/backend.dart:163: context.constantSystem, On 2015/03/12 12:38:07, Johnni Winther wrote: > Indent ...
5 years, 9 months ago (2015-03-12 14:05:18 UTC) #5
Kevin Millikin (Google)
5 years, 9 months ago (2015-03-13 09:33:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 44450 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698