Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1001733002: - Avoid rewrapping LoadError inside LoadError. (Closed)

Created:
5 years, 9 months ago by Ivan Posva
Modified:
5 years, 9 months ago
Reviewers:
rmacnak, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, nweiz
Visibility:
Public.

Description

- Avoid rewrapping LoadError inside LoadError. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=44419

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M runtime/bin/builtin.dart View 4 chunks +13 lines, -5 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Ivan Posva
5 years, 9 months ago (2015-03-11 23:45:26 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1001733002/diff/1/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/1001733002/diff/1/runtime/bin/builtin.dart#newcode301 runtime/bin/builtin.dart:301: var error = new LoadError(dataOrError.toString()); toString is redundant
5 years, 9 months ago (2015-03-11 23:50:52 UTC) #3
Ivan Posva
Thanks! -Ivan https://codereview.chromium.org/1001733002/diff/1/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/1001733002/diff/1/runtime/bin/builtin.dart#newcode301 runtime/bin/builtin.dart:301: var error = new LoadError(dataOrError.toString()); On 2015/03/11 ...
5 years, 9 months ago (2015-03-11 23:53:57 UTC) #4
Ivan Posva
5 years, 9 months ago (2015-03-11 23:54:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r44419 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698