Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 1001403002: Remove the old formatter from analyzer. (Closed)

Created:
5 years, 9 months ago by Bob Nystrom
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Remove the old formatter from analyzer. BUG=https://code.google.com/p/dart/issues/detail?id=22401 R=brianwilkerson@google.com, pquitslund@google.com Committed: https://code.google.com/p/dart/source/detail?r=44522

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5224 lines) Patch
D pkg/analyzer/bin/formatter.dart View 1 chunk +0 lines, -260 lines 0 comments Download
D pkg/analyzer/lib/formatter.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 2 chunks +0 lines, -25 lines 0 comments Download
D pkg/analyzer/lib/src/services/formatter_impl.dart View 1 chunk +0 lines, -1838 lines 0 comments Download
D pkg/analyzer/lib/src/services/writer.dart View 1 chunk +0 lines, -498 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/analyzer/test/services/data/cu_tests.data View 1 chunk +0 lines, -323 lines 0 comments Download
D pkg/analyzer/test/services/data/stmt_tests.data View 1 chunk +0 lines, -263 lines 0 comments Download
D pkg/analyzer/test/services/data/style_guide_tests.data View 1 chunk +0 lines, -238 lines 0 comments Download
D pkg/analyzer/test/services/data/wrap_tests.data View 1 chunk +0 lines, -155 lines 0 comments Download
D pkg/analyzer/test/services/formatter_test.dart View 1 chunk +0 lines, -1416 lines 0 comments Download
D pkg/analyzer/test/services/test_utils.dart View 1 chunk +0 lines, -192 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Bob Nystrom
How's this?
5 years, 9 months ago (2015-03-13 18:19:34 UTC) #2
pquitslund
lgtm https://codereview.chromium.org/1001403002/diff/1/pkg/analyzer/test/services/test_utils.dart File pkg/analyzer/test/services/test_utils.dart (left): https://codereview.chromium.org/1001403002/diff/1/pkg/analyzer/test/services/test_utils.dart#oldcode5 pkg/analyzer/test/services/test_utils.dart:5: library test_utils; Interesting that this is dead code. ...
5 years, 9 months ago (2015-03-13 22:42:38 UTC) #3
Brian Wilkerson
LGTM https://codereview.chromium.org/1001403002/diff/1/pkg/analyzer/test/services/test_utils.dart File pkg/analyzer/test/services/test_utils.dart (left): https://codereview.chromium.org/1001403002/diff/1/pkg/analyzer/test/services/test_utils.dart#oldcode5 pkg/analyzer/test/services/test_utils.dart:5: library test_utils; > Brian: any idea what the ...
5 years, 9 months ago (2015-03-14 00:11:59 UTC) #4
Bob Nystrom
5 years, 9 months ago (2015-03-16 20:03:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44522 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698