Issue 1001243003: Pass the call selector for local invocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1001243003: Pass the call selector for local invocations. (Closed)

Created:
5 years, 9 months ago by Johnni Winther

Modified:
5 years, 9 months ago

Reviewers:
karlklose, Anders Johnsen

CC:
reviews_dartlang.org, Anders Johnsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Pass the call selector for local invocations. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=44502

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -10 lines)			Patch
	M	pkg/compiler/lib/src/resolution/send_structure.dart	View		1 chunk	+9 lines, -3 lines	1 comment	Download
	M	tests/compiler/dart2js/semantic_visitor_test.dart	View		9 chunks	+15 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Anders Johnsen

DBC https://codereview.chromium.org/1001243003/diff/1/pkg/compiler/lib/src/resolution/send_structure.dart File pkg/compiler/lib/src/resolution/send_structure.dart (right): https://codereview.chromium.org/1001243003/diff/1/pkg/compiler/lib/src/resolution/send_structure.dart#newcode147 pkg/compiler/lib/src/resolution/send_structure.dart:147: // TODO(johnniwinther): Store the call selector instead of ...

5 years, 9 months ago (2015-03-13 11:46:37 UTC) #4

Johnni Winther

5 years, 9 months ago (2015-03-16 14:06:49 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44502 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages