Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1001063002: Correctly compute whether a class subclasses Function (issue 22805) (Closed)

Created:
5 years, 9 months ago by Brian Wilkerson
Modified:
5 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Correctly compute whether a class subclasses Function (issue 22805) R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -83 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 5 chunks +16 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 21 chunks +56 lines, -73 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
Sorry about the formatter churn.
5 years, 9 months ago (2015-03-12 18:08:47 UTC) #2
scheglov
LGTM
5 years, 9 months ago (2015-03-12 18:11:43 UTC) #3
Brian Wilkerson
5 years, 9 months ago (2015-03-12 19:01:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44439 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698