Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1000933004: Display ICData entries at call sites, with links to the targets and guarded classes. (Closed)

Created:
5 years, 9 months ago by rmacnak
Modified:
5 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Display ICData entries at call sites, with links to the targets and guarded classes. Implement service response for call site data for the same targets as coverage. Fix JSONifying ICData for super calls. BUG= Committed: https://code.google.com/p/dart/source/detail?r=44564

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : super calls #

Total comments: 4

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -285 lines) Patch
M runtime/observatory/lib/src/elements/function_view.dart View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/library_ref.html View 1 chunk +9 lines, -9 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.dart View 1 2 chunks +68 lines, -15 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 6 chunks +30 lines, -45 lines 0 comments Download
M runtime/observatory/test/call_site_data_test.dart View 1 2 3 chunks +105 lines, -103 lines 0 comments Download
M runtime/vm/coverage.h View 1 1 chunk +7 lines, -4 lines 0 comments Download
M runtime/vm/coverage.cc View 1 2 10 chunks +24 lines, -17 lines 0 comments Download
M runtime/vm/coverage_test.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/object.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 2 4 chunks +6 lines, -38 lines 0 comments Download
M runtime/vm/service.cc View 1 2 3 4 5 4 chunks +30 lines, -47 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
rmacnak
5 years, 9 months ago (2015-03-16 22:52:16 UTC) #2
Cutch
https://codereview.chromium.org/1000933004/diff/40001/runtime/observatory/lib/src/elements/class_view.dart File runtime/observatory/lib/src/elements/class_view.dart (right): https://codereview.chromium.org/1000933004/diff/40001/runtime/observatory/lib/src/elements/class_view.dart#newcode55 runtime/observatory/lib/src/elements/class_view.dart:55: Future.wait([cls.refreshCoverage(), Can we kill this redundancy? https://codereview.chromium.org/1000933004/diff/40001/runtime/vm/coverage.cc File runtime/vm/coverage.cc ...
5 years, 9 months ago (2015-03-17 17:05:05 UTC) #3
rmacnak
https://codereview.chromium.org/1000933004/diff/40001/runtime/observatory/lib/src/elements/class_view.dart File runtime/observatory/lib/src/elements/class_view.dart (right): https://codereview.chromium.org/1000933004/diff/40001/runtime/observatory/lib/src/elements/class_view.dart#newcode55 runtime/observatory/lib/src/elements/class_view.dart:55: Future.wait([cls.refreshCoverage(), On 2015/03/17 17:05:04, Cutch wrote: > Can we ...
5 years, 9 months ago (2015-03-18 19:24:05 UTC) #4
Cutch
LGTMwC https://codereview.chromium.org/1000933004/diff/80001/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/1000933004/diff/80001/runtime/vm/service.cc#newcode1743 runtime/vm/service.cc:1743: static bool GetCoverage(Isolate* isolate, JSONStream* js) { Add ...
5 years, 9 months ago (2015-03-18 19:53:52 UTC) #5
rmacnak
https://codereview.chromium.org/1000933004/diff/80001/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/1000933004/diff/80001/runtime/vm/service.cc#newcode1743 runtime/vm/service.cc:1743: static bool GetCoverage(Isolate* isolate, JSONStream* js) { On 2015/03/18 ...
5 years, 9 months ago (2015-03-18 20:06:47 UTC) #6
rmacnak
5 years, 9 months ago (2015-03-18 20:29:03 UTC) #7
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as 44564 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698