Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1000473002: Convert file system tests into reflective. (Closed)

Created:
5 years, 9 months ago by scheglov
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Convert file system tests into reflective. I need to add new tests... to add new methods... to fix issue 22757. It's too hard to do now. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+901 lines, -905 lines) Patch
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 1 chunk +513 lines, -527 lines 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 1 chunk +345 lines, -345 lines 0 comments Download
M pkg/analyzer/test/file_system/resource_uri_resolver_test.dart View 1 chunk +43 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 9 months ago (2015-03-10 21:45:23 UTC) #1
Brian Wilkerson
LGTM
5 years, 9 months ago (2015-03-10 22:42:52 UTC) #2
scheglov
5 years, 9 months ago (2015-03-11 00:03:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44389 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698