Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1000203004: Rename ListToX inputs. (Closed)

Created:
5 years, 9 months ago by scheglov
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Rename ListToX inputs. Also harder the GenerateTaskInputs interface. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -80 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +11 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/task/inputs.dart View 9 chunks +29 lines, -29 lines 0 comments Download
M pkg/analyzer/test/src/task/inputs_test.dart View 15 chunks +42 lines, -42 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 9 months ago (2015-03-12 21:45:31 UTC) #1
Brian Wilkerson
LGTM
5 years, 9 months ago (2015-03-12 21:54:17 UTC) #2
scheglov
5 years, 9 months ago (2015-03-12 21:57:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44446 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698