Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1000043003: dart2js: fix csp mode when minifying. (Closed)

Created:
5 years, 9 months ago by floitsch
Modified:
5 years, 9 months ago
Reviewers:
ricow1, zarah
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: fix csp mode when minifying. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=44453

Patch Set 1 #

Patch Set 2 : Remove --csp from _compileCommand #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
floitsch
5 years, 9 months ago (2015-03-12 15:22:49 UTC) #2
ricow1
lgtm
5 years, 9 months ago (2015-03-12 15:29:53 UTC) #3
floitsch
I updated the file to avoid double-csp flags. PTAL.
5 years, 9 months ago (2015-03-12 18:11:36 UTC) #4
ricow1
still lgtm
5 years, 9 months ago (2015-03-12 18:42:09 UTC) #5
floitsch
5 years, 9 months ago (2015-03-13 10:02:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44453 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698