Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9999041: Regression test for packing and installing an extension from an URL. (Closed)

Created:
8 years, 8 months ago by chebert
Modified:
8 years, 8 months ago
Reviewers:
Aaron Boodman
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Regression test for packing and installing an extension from an URL. BUG=120936 TEST=Regression test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132482

Patch Set 1 #

Patch Set 2 : more whitespace #

Patch Set 3 : Logging #

Total comments: 1

Patch Set 4 : VLOG -> LOG(ERROR) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M chrome/browser/download/download_crx_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 2 3 3 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Aaron Boodman
LGTM http://codereview.chromium.org/9999041/diff/3003/chrome/browser/extensions/crx_installer_browsertest.cc File chrome/browser/extensions/crx_installer_browsertest.cc (right): http://codereview.chromium.org/9999041/diff/3003/chrome/browser/extensions/crx_installer_browsertest.cc#newcode130 chrome/browser/extensions/crx_installer_browsertest.cc:130: VLOG(1) << "PackAndInstallExtension: Packing extension"; I would not ...
8 years, 8 months ago (2012-04-11 00:12:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hebert.christopherj@chromium.org/9999041/6001
8 years, 8 months ago (2012-04-13 23:28:29 UTC) #2
commit-bot: I haz the power
Try job failure for 9999041-6001 (retry) (retry) on mac_rel for step "compile" (clobber build). It's ...
8 years, 8 months ago (2012-04-14 01:36:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hebert.christopherj@chromium.org/9999041/6001
8 years, 8 months ago (2012-04-14 17:41:54 UTC) #4
commit-bot: I haz the power
Try job failure for 9999041-6001 (retry) on win_rel for step "base_unittests". It's a second try, ...
8 years, 8 months ago (2012-04-14 21:19:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hebert.christopherj@chromium.org/9999041/6001
8 years, 8 months ago (2012-04-16 21:23:27 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-16 22:59:41 UTC) #7 
Change committed as 132482

Powered by Google App Engine
This is Rietveld 408576698