Attempt to close idle connections in higher layer socket pools when a lower layer pool is stalled.

Attempt to close idle connections in higher layer socket pools when a lower layer pool is stalled.

BUG=62364, 92244
TEST=ClientSocketPoolBaseTest.\*CloseIdleSocket\*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132478

[Ryan Hamilton, 2012-04-10 18:54:37]

Here is the 2nd CL in the this series.  I will not land it until we have
feedback from the first CL.

[willchan no longer on Chromium, 2012-04-11 11:14:46]

lgtm

http://codereview.chromium.org/9999030/diff/1/net/socket/client_socket_pool_b...
File net/socket/client_socket_pool_base.cc (right):

http://codereview.chromium.org/9999030/diff/1/net/socket/client_socket_pool_b...
net/socket/client_socket_pool_base.cc:375: // requires a scan of all groups, so
just flip a flag here, and do
Stale comment? I don't think we flip a flag anymore.

[mmenke, 2012-04-11 14:09:04]

LGTM as well

[Ryan Hamilton, 2012-04-16 20:51:54]

http://codereview.chromium.org/9999030/diff/1/net/socket/client_socket_pool_b...
File net/socket/client_socket_pool_base.cc (right):

http://codereview.chromium.org/9999030/diff/1/net/socket/client_socket_pool_b...
net/socket/client_socket_pool_base.cc:375: // requires a scan of all groups, so
just flip a flag here, and do
On 2012/04/11 11:14:47, willchan wrote:
> Stale comment? I don't think we flip a flag anymore.

Missed your comment earlier.  Done.

[commit-bot: I haz the power, 2012-04-16 20:52:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/9999030/5001

[commit-bot: I haz the power, 2012-04-16 20:54:33]

Try job failure for 9999030-5001 on linux_clang for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-04-16 21:09:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/9999030/5001

[commit-bot: I haz the power, 2012-04-16 22:37:37]

Change committed as 132478