Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issue 9999010: Store original request URL in NavigationEntry (Closed)

Created:
8 years, 8 months ago by gone
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Store original request URL in NavigationEntry We need the original request URL when requesting desktop sites for situations where we end up redirected to a page where no user agent detection is performed. * Adds a OriginalRequestURL field to NavigationEntry. * Saves out the OriginalRequestURL as part of the NavigationEntry. Part of upstreaming for b/5119921 BUG=112923 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132647

Patch Set 1 #

Patch Set 2 : Correcting bug #

Patch Set 3 : Added to unit test #

Total comments: 9

Patch Set 4 : Addressing reviewer comment #

Patch Set 5 : Addressing sky's comments #

Patch Set 6 : Rebasing #

Patch Set 7 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -2 lines) Patch
M chrome/browser/sessions/base_session_service.cc View 1 2 3 4 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_service_test_helper.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_types.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_types.cc View 4 chunks +5 lines, -1 line 0 comments Download
M content/browser/web_contents/navigation_controller_impl.cc View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/web_contents/navigation_entry_impl.h View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/web_contents/navigation_entry_impl.cc View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/web_contents/navigation_entry_impl_unittest.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/browser/navigation_entry.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
gone
I ended up going with the explicit storage of the original URL in the NavigationEntry, ...
8 years, 8 months ago (2012-04-10 00:50:49 UTC) #1
Charlie Reis
Seems reasonable to me. Not sure why we would store an empty URL when there ...
8 years, 8 months ago (2012-04-10 01:37:28 UTC) #2
gone
https://chromiumcodereview.appspot.com/9999010/diff/1011/chrome/browser/sessions/base_session_service.cc File chrome/browser/sessions/base_session_service.cc (right): https://chromiumcodereview.appspot.com/9999010/diff/1011/chrome/browser/sessions/base_session_service.cc#newcode194 chrome/browser/sessions/base_session_service.cc:194: // Adding more data? Be sure and update TabRestoreService ...
8 years, 8 months ago (2012-04-10 17:41:33 UTC) #3
Charlie Reis
LGTM. I'd prefer to get Scott's eyes on the session restore stuff, though. https://chromiumcodereview.appspot.com/9999010/diff/1011/chrome/browser/sessions/base_session_service.cc File ...
8 years, 8 months ago (2012-04-11 20:31:01 UTC) #4
sky
LGTM https://chromiumcodereview.appspot.com/9999010/diff/1011/chrome/browser/sessions/base_session_service.cc File chrome/browser/sessions/base_session_service.cc (right): https://chromiumcodereview.appspot.com/9999010/diff/1011/chrome/browser/sessions/base_session_service.cc#newcode194 chrome/browser/sessions/base_session_service.cc:194: // Adding more data? Be sure and update ...
8 years, 8 months ago (2012-04-11 21:20:25 UTC) #5
gone
https://chromiumcodereview.appspot.com/9999010/diff/1011/chrome/browser/sessions/base_session_service.cc File chrome/browser/sessions/base_session_service.cc (right): https://chromiumcodereview.appspot.com/9999010/diff/1011/chrome/browser/sessions/base_session_service.cc#newcode194 chrome/browser/sessions/base_session_service.cc:194: // Adding more data? Be sure and update TabRestoreService ...
8 years, 8 months ago (2012-04-12 18:13:35 UTC) #6
gone
Expanding reviewer list with an owner for content/public/
8 years, 8 months ago (2012-04-16 19:10:20 UTC) #7
Jói
LGTM for content/public. Sorry for the delay, was on vacation yesterday. Cheers, Jói
8 years, 8 months ago (2012-04-17 09:35:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/9999010/17002
8 years, 8 months ago (2012-04-17 18:35:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/9999010/17002
8 years, 8 months ago (2012-04-17 18:38:24 UTC) #10
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 21:12:51 UTC) #11
Change committed as 132647

Powered by Google App Engine
This is Rietveld 408576698