Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: webkit/dom_storage/dom_storage_task_runner.h

Issue 9997007: Objects that derive from RefCounted/RefCountedThreadSafe should not have public dtors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: virtual & DISALLOW Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/base/plugin_message_loop_proxy.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/dom_storage/dom_storage_task_runner.h
diff --git a/webkit/dom_storage/dom_storage_task_runner.h b/webkit/dom_storage/dom_storage_task_runner.h
index c7b5fd585914dd954f06d9a5c6b90a5378c9ac5c..8cb0e7903a78170b036878dc66b90af717c60ae9 100644
--- a/webkit/dom_storage/dom_storage_task_runner.h
+++ b/webkit/dom_storage/dom_storage_task_runner.h
@@ -55,6 +55,9 @@ class DomStorageTaskRunner : public base::TaskRunner {
const tracked_objects::Location& from_here,
const base::Closure& task,
int64 delay_ms) OVERRIDE;
+
+ protected:
+ virtual ~DomStorageTaskRunner() {}
};
// A derived class used in chromium that utilizes a SequenceWorkerPool
@@ -78,8 +81,10 @@ class DomStorageWorkerPoolTaskRunner : public DomStorageTaskRunner {
SequenceID sequence_id,
const base::Closure& task) OVERRIDE;
- private:
+ protected:
virtual ~DomStorageWorkerPoolTaskRunner();
+
+ private:
const scoped_refptr<base::MessageLoopProxy> message_loop_;
const scoped_refptr<base::SequencedWorkerPool> sequenced_worker_pool_;
base::SequencedWorkerPool::SequenceToken primary_sequence_token_;
@@ -105,8 +110,10 @@ class MockDomStorageTaskRunner : public DomStorageTaskRunner {
SequenceID sequence_id,
const base::Closure& task) OVERRIDE;
- private:
+ protected:
virtual ~MockDomStorageTaskRunner();
+
+ private:
const scoped_refptr<base::MessageLoopProxy> message_loop_;
};
« no previous file with comments | « remoting/base/plugin_message_loop_proxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698