Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: base/threading/worker_pool_posix.h

Issue 9997007: Objects that derive from RefCounted/RefCountedThreadSafe should not have public dtors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: virtual & DISALLOW Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/synchronization/waitable_event_watcher_posix.cc ('k') | remoting/base/plugin_message_loop_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/worker_pool_posix.h
diff --git a/base/threading/worker_pool_posix.h b/base/threading/worker_pool_posix.h
index f56582de3b57fd8611a42bdf71a75e109429cd16..eca113a8791cfbaff7ff9730455d5dbceba50096 100644
--- a/base/threading/worker_pool_posix.h
+++ b/base/threading/worker_pool_posix.h
@@ -53,7 +53,6 @@ class BASE_EXPORT PosixDynamicThreadPool
// |idle_seconds_before_exit|.
PosixDynamicThreadPool(const std::string& name_prefix,
int idle_seconds_before_exit);
- ~PosixDynamicThreadPool();
// Indicates that the thread pool is going away. Stops handing out tasks to
// worker threads. Wakes up all the idle threads to let them exit.
@@ -68,8 +67,11 @@ class BASE_EXPORT PosixDynamicThreadPool
PendingTask WaitForTask();
private:
+ friend class RefCountedThreadSafe<PosixDynamicThreadPool>;
friend class PosixDynamicThreadPoolPeer;
+ ~PosixDynamicThreadPool();
+
// Adds pending_task to the thread pool. This function will clear
// |pending_task->task|.
void AddTask(PendingTask* pending_task);
« no previous file with comments | « base/synchronization/waitable_event_watcher_posix.cc ('k') | remoting/base/plugin_message_loop_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698