Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2735)

Unified Diff: base/message_pump_default.h

Issue 9997007: Objects that derive from RefCounted/RefCountedThreadSafe should not have public dtors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: virtual & DISALLOW Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_pump.h ('k') | base/message_pump_libevent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_pump_default.h
diff --git a/base/message_pump_default.h b/base/message_pump_default.h
index c16abcfacd3563447e00423aa97ecd161cdc8cc8..41a436ca89d0bd057e9b8a94a030e3f98db6bb4a 100644
--- a/base/message_pump_default.h
+++ b/base/message_pump_default.h
@@ -15,7 +15,6 @@ namespace base {
class MessagePumpDefault : public MessagePump {
public:
MessagePumpDefault();
- virtual ~MessagePumpDefault() {}
// MessagePump methods:
virtual void Run(Delegate* delegate) OVERRIDE;
@@ -23,6 +22,9 @@ class MessagePumpDefault : public MessagePump {
virtual void ScheduleWork() OVERRIDE;
virtual void ScheduleDelayedWork(const TimeTicks& delayed_work_time) OVERRIDE;
+ protected:
+ virtual ~MessagePumpDefault() {}
+
private:
// This flag is set to false when Run should return.
bool keep_running_;
« no previous file with comments | « base/message_pump.h ('k') | base/message_pump_libevent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698