Objects that derive from RefCounted/RefCountedThreadSafe should not have public dtors.

webkit/dom_storage/dom_storage_task_runner.h

Index: webkit/dom_storage/dom_storage_task_runner.h
diff --git a/webkit/dom_storage/dom_storage_task_runner.h b/webkit/dom_storage/dom_storage_task_runner.h
index c7b5fd585914dd954f06d9a5c6b90a5378c9ac5c..8cb0e7903a78170b036878dc66b90af717c60ae9 100644
--- a/webkit/dom_storage/dom_storage_task_runner.h
+++ b/webkit/dom_storage/dom_storage_task_runner.h
@@ -55,6 +55,9 @@ class DomStorageTaskRunner : public base::TaskRunner {
       const tracked_objects::Location& from_here,
       const base::Closure& task,
       int64 delay_ms) OVERRIDE;
+
+ protected:
+  virtual ~DomStorageTaskRunner() {}
 };
 
 // A derived class used in chromium that utilizes a SequenceWorkerPool
@@ -78,8 +81,10 @@ class DomStorageWorkerPoolTaskRunner : public DomStorageTaskRunner {
       SequenceID sequence_id,
       const base::Closure& task) OVERRIDE;
 
- private:
+ protected:
   virtual ~DomStorageWorkerPoolTaskRunner();

[michaeln, 2012/04/05 18:42:10]

why the change from private to protected, just curious?

[Ryan Sleevi, 2012/04/05 19:18:12]

The base class this is derived from is protected. So declaring it private
doesn't really do what is expected - as they can always upcast to the base type
to delete it.

While the change wasn't functionally necessary, derived classes should keep or
expand visibility of their base classes, not restrict it.

+
+ private:
   const scoped_refptr<base::MessageLoopProxy> message_loop_;
   const scoped_refptr<base::SequencedWorkerPool> sequenced_worker_pool_;
   base::SequencedWorkerPool::SequenceToken primary_sequence_token_;
@@ -105,8 +110,10 @@ class MockDomStorageTaskRunner : public DomStorageTaskRunner {
       SequenceID sequence_id,
       const base::Closure& task) OVERRIDE;
 
- private:
+ protected:
   virtual ~MockDomStorageTaskRunner();
+
+ private:
   const scoped_refptr<base::MessageLoopProxy> message_loop_;
 };