Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: base/message_loop_proxy_impl.h

Issue 9997007: Objects that derive from RefCounted/RefCountedThreadSafe should not have public dtors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: virtual & DISALLOW Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | base/message_pump.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_MESSAGE_LOOP_PROXY_IMPL_H_ 5 #ifndef BASE_MESSAGE_LOOP_PROXY_IMPL_H_
6 #define BASE_MESSAGE_LOOP_PROXY_IMPL_H_ 6 #define BASE_MESSAGE_LOOP_PROXY_IMPL_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/base_export.h" 9 #include "base/base_export.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
11 #include "base/message_loop_proxy.h" 11 #include "base/message_loop_proxy.h"
12 #include "base/synchronization/lock.h" 12 #include "base/synchronization/lock.h"
13 13
14 namespace base { 14 namespace base {
15 15
16 // A stock implementation of MessageLoopProxy that is created and managed by a 16 // A stock implementation of MessageLoopProxy that is created and managed by a
17 // MessageLoop. For now a MessageLoopProxyImpl can only be created as part of a 17 // MessageLoop. For now a MessageLoopProxyImpl can only be created as part of a
18 // MessageLoop. 18 // MessageLoop.
19 class BASE_EXPORT MessageLoopProxyImpl 19 class BASE_EXPORT MessageLoopProxyImpl : public MessageLoopProxy {
20 : public MessageLoopProxy {
21 public: 20 public:
22 virtual ~MessageLoopProxyImpl();
23
24 // MessageLoopProxy implementation 21 // MessageLoopProxy implementation
25 virtual bool PostDelayedTask(const tracked_objects::Location& from_here, 22 virtual bool PostDelayedTask(const tracked_objects::Location& from_here,
26 const base::Closure& task, 23 const base::Closure& task,
27 int64 delay_ms) OVERRIDE; 24 int64 delay_ms) OVERRIDE;
28 virtual bool PostDelayedTask(const tracked_objects::Location& from_here, 25 virtual bool PostDelayedTask(const tracked_objects::Location& from_here,
29 const base::Closure& task, 26 const base::Closure& task,
30 base::TimeDelta delay) OVERRIDE; 27 base::TimeDelta delay) OVERRIDE;
31 virtual bool PostNonNestableDelayedTask( 28 virtual bool PostNonNestableDelayedTask(
32 const tracked_objects::Location& from_here, 29 const tracked_objects::Location& from_here,
33 const base::Closure& task, 30 const base::Closure& task,
34 int64 delay_ms) OVERRIDE; 31 int64 delay_ms) OVERRIDE;
35 virtual bool PostNonNestableDelayedTask( 32 virtual bool PostNonNestableDelayedTask(
36 const tracked_objects::Location& from_here, 33 const tracked_objects::Location& from_here,
37 const base::Closure& task, 34 const base::Closure& task,
38 base::TimeDelta delay) OVERRIDE; 35 base::TimeDelta delay) OVERRIDE;
39 virtual bool RunsTasksOnCurrentThread() const OVERRIDE; 36 virtual bool RunsTasksOnCurrentThread() const OVERRIDE;
40 37
41 protected: 38 protected:
39 virtual ~MessageLoopProxyImpl();
40
42 // Override OnDestruct so that we can delete the object on the target message 41 // Override OnDestruct so that we can delete the object on the target message
43 // loop if it still exists. 42 // loop if it still exists.
44 virtual void OnDestruct() const OVERRIDE; 43 virtual void OnDestruct() const OVERRIDE;
45 44
46 private: 45 private:
46 // Allow the MessageLoop to create a MessageLoopProxyImpl.
47 friend class ::MessageLoop;
48 friend class DeleteHelper<MessageLoopProxyImpl>;
49
47 MessageLoopProxyImpl(); 50 MessageLoopProxyImpl();
48 51
49 // Called directly by MessageLoop::~MessageLoop. 52 // Called directly by MessageLoop::~MessageLoop.
50 virtual void WillDestroyCurrentMessageLoop(); 53 virtual void WillDestroyCurrentMessageLoop();
51 54
52 55
53 bool PostTaskHelper(const tracked_objects::Location& from_here, 56 bool PostTaskHelper(const tracked_objects::Location& from_here,
54 const base::Closure& task, 57 const base::Closure& task,
55 base::TimeDelta delay, 58 base::TimeDelta delay,
56 bool nestable); 59 bool nestable);
57 60
58 // Allow the messageLoop to create a MessageLoopProxyImpl.
59 friend class ::MessageLoop;
60
61 // The lock that protects access to target_message_loop_. 61 // The lock that protects access to target_message_loop_.
62 mutable base::Lock message_loop_lock_; 62 mutable base::Lock message_loop_lock_;
63 MessageLoop* target_message_loop_; 63 MessageLoop* target_message_loop_;
64 64
65 DISALLOW_COPY_AND_ASSIGN(MessageLoopProxyImpl); 65 DISALLOW_COPY_AND_ASSIGN(MessageLoopProxyImpl);
66 }; 66 };
67 67
68 } // namespace base 68 } // namespace base
69 69
70 #endif // BASE_MESSAGE_LOOP_PROXY_IMPL_H_ 70 #endif // BASE_MESSAGE_LOOP_PROXY_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | base/message_pump.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698