Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1831)

Issue 9989001: Don't show failure of the last succeeded test (Closed)

Created:
8 years, 8 months ago by Xianzhu
Modified:
8 years, 8 months ago
Reviewers:
John Grabowski, jrg
CC:
chromium-reviews
Visibility:
Public.

Description

Don't show failure of the last succeeded test Before this change, if some test failed before the last test succeeded, because of the return value, the buildbot will show that the last test also failed. Add a summary build step to avoid that. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/android/run_tests.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Xianzhu
8 years, 8 months ago (2012-04-04 22:38:47 UTC) #1
John Grabowski
LGTM Thx for following up on spinoff issues
8 years, 8 months ago (2012-04-04 22:56:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/9989001/1
8 years, 8 months ago (2012-04-04 22:58:53 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-05 02:53:30 UTC) #4
Change committed as 130823

Powered by Google App Engine
This is Rietveld 408576698