Adjust location of text in omnibox edit control for Metro.

chrome/browser/ui/views/omnibox/omnibox_view_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_win.h"
 
 #include <algorithm>
 #include <locale>
 #include <string>
 
@@ skipping 418 matching lines @@
 // to set offsets.
 const int kTwipsPerInch = 1440;
 
 }  // namespace
 
 OmniboxViewWin::OmniboxViewWin(AutocompleteEditController* controller,
                                ToolbarModel* toolbar_model,
                                LocationBarView* parent_view,
                                CommandUpdater* command_updater,
                                bool popup_window_mode,
+                               int height,
                                views::View* location_bar)
     : model_(new AutocompleteEditModel(this, controller,
                                        parent_view->profile())),
       popup_view_(AutocompletePopupContentsView::CreateForEnvironment(
           parent_view->font(), this, model_.get(), location_bar)),
       controller_(controller),
       parent_view_(parent_view),
       toolbar_model_(toolbar_model),
       command_updater_(command_updater),
       popup_window_mode_(popup_window_mode),
@@ skipping 40 matching lines @@
   // NOTE: Do not use SetWordBreakProcEx() here, that is no longer supported as
   // of Rich Edit 2.0 onward.
   SendMessage(m_hWnd, EM_SETWORDBREAKPROC, 0,
               reinterpret_cast<LPARAM>(&WordBreakProc));
 
   // Get the metrics for the font.
   HDC hdc = ::GetDC(NULL);
   HGDIOBJ old_font = SelectObject(hdc, font_.GetNativeFont());
   TEXTMETRIC tm = {0};
   GetTextMetrics(hdc, &tm);
-  const float kXHeightRatio = 0.7f;  // The ratio of a font's x-height to its
-                                     // cap height.  Sadly, Windows doesn't
-                                     // provide a true value for a font's
-                                     // x-height in its text metrics, so we
-                                     // approximate.
-  font_x_height_ = static_cast<int>((static_cast<float>(font_.GetBaseline() -
-      tm.tmInternalLeading) * kXHeightRatio) + 0.5);
-  // The distance from the top of the field to the desired baseline of the
-  // rendered text.
-  const int kTextBaseline = popup_window_mode_ ? 15 : 18;
-  font_y_adjustment_ = kTextBaseline - font_.GetBaseline();
+  int cap_height = font_.GetBaseline() - tm.tmInternalLeading;
+  // The ratio of a font's x-height to its cap height.  Sadly, Windows
+  // doesn't provide a true value for a font's x-height in its text
+  // metrics, so we approximate.
+  const float kXHeightRatio = 0.7f;
+  font_x_height_ = static_cast<int>(
+      (static_cast<float>(cap_height) * kXHeightRatio) + 0.5);
+
+  // We set font_y_adjustment_ so that the ascender of the font gets
+  // centered on the available height of the view.

[Peter Kasting, 2012/05/16 23:19:50]

You did check that this produces identical results to the current code on
non-Metro, right?

+  font_y_adjustment_ =
+      (height - cap_height) / 2 + cap_height - font_.GetBaseline();

[Peter Kasting, 2012/05/16 23:19:50]

Nit: Simpler:

  font_y_adjustment_ = ((height - cap_height) / 2) - tm.tmInternalLeading;

 
   // Get the number of twips per pixel, which we need below to offset our text
   // by the desired number of pixels.
   const long kTwipsPerPixel = kTwipsPerInch / GetDeviceCaps(hdc, LOGPIXELSY);
   // It's unsafe to delete a DC with a non-stock object selected, so restore the
   // original font.
   SelectObject(hdc, old_font);
   ::ReleaseDC(NULL, hdc);
 
   // Set the default character style -- adjust to our desired baseline.
@@ skipping 2155 matching lines @@
 }
 
 #if !defined(USE_AURA)
 // static
 OmniboxView* OmniboxView::CreateOmniboxView(
     AutocompleteEditController* controller,
     ToolbarModel* toolbar_model,
     Profile* profile,
     CommandUpdater* command_updater,
     bool popup_window_mode,
+    int height,
     LocationBarView* location_bar) {
   return new OmniboxViewWin(controller,
                             toolbar_model,
                             location_bar,
                             command_updater,
                             popup_window_mode,
+                            height,
                             location_bar);
 }
 #endif