Allow SessionService to be disabled.

Allow SessionService to be disabled.

Android manages persistence of sessions separately in Java code.

BUG=117407
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130976

[Yaron, 2012-04-04 20:34:46]

mirandac: chrome/browser/profiles
sky: the rest

This is picking up where 9481017 left off.

I've switched to the agreed-upon cleaner approach of having a feature-specific
define and removed all references to it (as verified by linking).

I also took the opportunity to reorganize 
ProfileDependencyManager::AssertFactoriesBuilt to match what's been requested in
other places like GetWebUIFactoryFunction and browser::RegisterLocalState and
browser::RegisterUserPrefs. I assume the ordering doesn't matter and this seems
arguably cleaner

[sky, 2012-04-04 21:04:51]

I suspect you'll want to update both chrome_tests.gypi and potentially some of
the tabrestoreservice tests.

http://codereview.chromium.org/9985002/diff/4001/chrome/browser/browsing_data...
File chrome/browser/browsing_data_remover.cc (right):

http://codereview.chromium.org/9985002/diff/4001/chrome/browser/browsing_data...
chrome/browser/browsing_data_remover.cc:245: SessionService* session_service =
Are there some includes that should be moved behind the ifdef too?

http://codereview.chromium.org/9985002/diff/4001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/9985002/diff/4001/chrome/chrome_browser.gypi#n...
chrome/chrome_browser.gypi:4489: 'browser/sessions/session_restore.cc',
Don't you want to remove the .h's too?

[Miranda Callahan, 2012-04-04 21:24:29]

On 2012/04/04 21:04:51, sky wrote:
> I suspect you'll want to update both chrome_tests.gypi and potentially some of
> the tabrestoreservice tests.
> 
>
http://codereview.chromium.org/9985002/diff/4001/chrome/browser/browsing_data...
> File chrome/browser/browsing_data_remover.cc (right):
> 
>
http://codereview.chromium.org/9985002/diff/4001/chrome/browser/browsing_data...
> chrome/browser/browsing_data_remover.cc:245: SessionService* session_service =
> Are there some includes that should be moved behind the ifdef too?
> 
> http://codereview.chromium.org/9985002/diff/4001/chrome/chrome_browser.gypi
> File chrome/chrome_browser.gypi (right):
> 
>
http://codereview.chromium.org/9985002/diff/4001/chrome/chrome_browser.gypi#n...
> chrome/chrome_browser.gypi:4489: 'browser/sessions/session_restore.cc',
> Don't you want to remove the .h's too?

profiles/* LGTM.

[Yaron, 2012-04-04 21:36:18]

Looks like the tabrestoreservice tests are browser tests so they're out of scope
for the foreseeable future.

http://codereview.chromium.org/9985002/diff/4001/chrome/browser/browsing_data...
File chrome/browser/browsing_data_remover.cc (right):

http://codereview.chromium.org/9985002/diff/4001/chrome/browser/browsing_data...
chrome/browser/browsing_data_remover.cc:245: SessionService* session_service =
On 2012/04/04 21:04:51, sky wrote:
> Are there some includes that should be moved behind the ifdef too?

jam@ requested that we introduce less if-defs and not if-def headers unless
they're including new Android-specific code.

http://codereview.chromium.org/9985002/diff/4001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/9985002/diff/4001/chrome/chrome_browser.gypi#n...
chrome/chrome_browser.gypi:4489: 'browser/sessions/session_restore.cc',
On 2012/04/04 21:04:51, sky wrote:
> Don't you want to remove the .h's too?

I suppose I could but I thought that it doesn't matter. In other words, the .h
will be included regardless of what gyp says and I thought gyp would only govern
what .o files are included. It doesn't hurt though, so I added it. Or maybe it
also matters for non-make/ninja builds?

[sky, 2012-04-04 22:33:49]

LGTM

I like removing the headers from the project as presumably that results in
smaller make/ninja files. Also it should mean that if you happen to touch one of
the headers your build doesn't need to recompile.

[commit-bot: I haz the power, 2012-04-04 23:30:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9985002/6002

[commit-bot: I haz the power, 2012-04-04 23:30:48]

Can't apply patch for file chrome/chrome_browser.gypi.
While running patch -p1 --forward --force;
patching file chrome/chrome_browser.gypi
Hunk #1 succeeded at 4480 (offset -4 lines).
Hunk #2 FAILED at 4526.
1 out of 2 hunks FAILED -- saving rejects to file chrome/chrome_browser.gypi.rej

[commit-bot: I haz the power, 2012-04-05 14:57:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9985002/6002

[commit-bot: I haz the power, 2012-04-05 18:34:56]

Change committed as 130976