Issue 998007: Add debug code assertions where we expect smi inputs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 998007: Add debug code assertions where we expect smi inputs. (Closed)

Created:
10 years, 9 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Add debug code assertions where we expect smi inputs. Committed: http://code.google.com/p/v8/source/detail?r=4187

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -28 lines)			Patch
M	src/ia32/codegen-ia32.cc	View	1	26 chunks	+52 lines, -22 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

fschneider

Small code review. For consistency I added debug code assertions at all places where we ...

10 years, 9 months ago (2010-03-17 18:55:46 UTC) #1

LGTM