Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 9980022: Add dependencies to webkit pieces. (Closed)

Created:
8 years, 8 months ago by Peter Mayo
Modified:
8 years, 8 months ago
Reviewers:
kinuko
CC:
sadrul, chromium-reviews, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

Add dependencies to webkit pieces. libcompositor (.so) gets linked against libwebkit_fileapi (.a) and libwebkit_quota (.a), each of which is built with googleurl, but does not include it as a dependency, causing libcompositor (.so) to not include all of the symbols it requires. R=kinuko@chromium.org BUG=112626 TEST=Compiled chromeos with shared library on a buildbot like setup. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132201

Patch Set 1 #

Patch Set 2 : rebased to 130926 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webkit/fileapi/webkit_fileapi.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/quota/webkit_quota.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Peter Mayo
This uses the same style as I found googleurl referenced in other gypi files in ...
8 years, 8 months ago (2012-04-12 01:37:47 UTC) #1
Peter Mayo
Note: Previous try failures were based on troubles with the client/checkout from which I issued ...
8 years, 8 months ago (2012-04-13 01:42:52 UTC) #2
kinuko
On 2012/04/13 01:42:52, Peter Mayo wrote: > Note: Previous try failures were based on troubles ...
8 years, 8 months ago (2012-04-13 02:51:58 UTC) #3
Peter Mayo
the linux chromeos failures look stable. Does the linkage change the sharedness? Does having the ...
8 years, 8 months ago (2012-04-13 04:09:18 UTC) #4
kinuko
Aren't they just flaky? The last two try result doesn't look like a linkage issue ...
8 years, 8 months ago (2012-04-13 11:42:04 UTC) #5
Peter Mayo
On 2012/04/13 11:42:04, kinuko wrote: > Aren't they just flaky? The last two try result ...
8 years, 8 months ago (2012-04-13 14:52:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petermayo@chromium.org/9980022/4002
8 years, 8 months ago (2012-04-13 15:41:05 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 17:08:59 UTC) #8
Change committed as 132201

Powered by Google App Engine
This is Rietveld 408576698