The Chrome Remote Desktop installation for Windows can be build by bots now.

The Chrome Remote Desktop installation for Windows can be build by bots now.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131239

[alexeypa (please no reviews), 2012-04-04 20:32:29]

Please take a look.

[Sergey Ulanov, 2012-04-04 22:45:13]

http://codereview.chromium.org/9980015/diff/1/chrome/tools/build/win/FILES.cfg
File chrome/tools/build/win/FILES.cfg (right):

http://codereview.chromium.org/9980015/diff/1/chrome/tools/build/win/FILES.cf...
chrome/tools/build/win/FILES.cfg:418: 'filename': 'chromoting.msi',
maybe call it remoting-host.msi - for consistency with the webapp target?

[alexeypa (please no reviews), 2012-04-04 23:29:31]

http://codereview.chromium.org/9980015/diff/1/chrome/tools/build/win/FILES.cfg
File chrome/tools/build/win/FILES.cfg (right):

http://codereview.chromium.org/9980015/diff/1/chrome/tools/build/win/FILES.cf...
chrome/tools/build/win/FILES.cfg:418: 'filename': 'chromoting.msi',
On 2012/04/04 22:45:13, sergeyu wrote:
> maybe call it remoting-host.msi - for consistency with the webapp target?

Currently we use "ChromeRemoteDesktop.msi" for download URLs in Lorry. I think
we should use the same name in both places. In any case the word "host" is
missing from the download URL. Gary, what do you think?

[garykac, 2012-04-04 23:48:28]

Seems reasonable.

We should probably also use "Chrome Remote Desktop Host" in our installer
whenever it's visible to the user.  I know that the Mac has a few instances
where I used simply "Chrome Remote Desktop" that I'll need to fixup.

On Wed, Apr 4, 2012 at 4:29 PM, <alexeypa@chromium.org> wrote:

>
> http://codereview.chromium.**org/9980015/diff/1/chrome/**
>
tools/build/win/FILES.cfg<http://codereview.chromium.org/9980015/diff/1/chrome/tools/build/win/FILES.cfg>
> File chrome/tools/build/win/FILES.**cfg (right):
>
> http://codereview.chromium.**org/9980015/diff/1/chrome/**
>
tools/build/win/FILES.cfg#**newcode418<http://codereview.chromium.org/9980015/diff/1/chrome/tools/build/win/FILES.cfg#newcode418>
> chrome/tools/build/win/FILES.**cfg:418: 'filename': 'chromoting.msi',
> On 2012/04/04 22:45:13, sergeyu wrote:
>
>> maybe call it remoting-host.msi - for consistency with the webapp
>>
> target?
>
> Currently we use "ChromeRemoteDesktop.msi" for download URLs in Lorry. I
> think we should use the same name in both places. In any case the word
> "host" is missing from the download URL. Gary, what do you think?
>
>
http://codereview.chromium.**org/9980015/<http://codereview.chromium.org/9980...
>

[alexeypa (please no reviews), 2012-04-05 00:09:15]

I changed the name to remoting-host.msi. The name in the download URL can still
be different.

http://codereview.chromium.org/9980015/diff/1/chrome/tools/build/win/FILES.cfg
File chrome/tools/build/win/FILES.cfg (right):

http://codereview.chromium.org/9980015/diff/1/chrome/tools/build/win/FILES.cf...
chrome/tools/build/win/FILES.cfg:418: 'filename': 'chromoting.msi',
On 2012/04/04 22:45:13, sergeyu wrote:
> maybe call it remoting-host.msi - for consistency with the webapp target?

Done.

[Sergey Ulanov, 2012-04-05 00:43:31]

http://codereview.chromium.org/9980015/diff/10001/chrome/tools/build/win/FILE...
File chrome/tools/build/win/FILES.cfg (right):

http://codereview.chromium.org/9980015/diff/10001/chrome/tools/build/win/FILE...
chrome/tools/build/win/FILES.cfg:421: 'archive': 'remoting-host.msi',
Read comments at the top of this file. If archive!=filename then it means you
want the file will be zipped to the file with the name specified here. I think
we should change filename too, or specify direct_archive

[alexeypa (please no reviews), 2012-04-05 05:00:11]

http://codereview.chromium.org/9980015/diff/10001/chrome/tools/build/win/FILE...
File chrome/tools/build/win/FILES.cfg (right):

http://codereview.chromium.org/9980015/diff/10001/chrome/tools/build/win/FILE...
chrome/tools/build/win/FILES.cfg:421: 'archive': 'remoting-host.msi',
On 2012/04/05 00:43:31, sergeyu wrote:
> we should change filename too, or specify direct_archive

This is exactly what I did. I added direct_archive. See the line below. :-)

[Sergey Ulanov, 2012-04-05 07:05:41]

Lgtm

http://codereview.chromium.org/9980015/diff/10001/chrome/tools/build/win/FILE...
File chrome/tools/build/win/FILES.cfg (right):

http://codereview.chromium.org/9980015/diff/10001/chrome/tools/build/win/FILE...
chrome/tools/build/win/FILES.cfg:421: 'archive': 'remoting-host.msi',
On 2012/04/05 05:00:12, alexeypa wrote:
> On 2012/04/05 00:43:31, sergeyu wrote:
> > we should change filename too, or specify direct_archive
> 
> This is exactly what I did. I added direct_archive. See the line below. :-)
> 

Ouch. Sorry I missed it.

[commit-bot: I haz the power, 2012-04-05 22:30:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/9980015/16001

[commit-bot: I haz the power, 2012-04-06 02:27:08]

Try job failure for 9980015-16001 (retry) (previous was lost) on win_rel for
step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-04-06 23:18:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/9980015/24001

[commit-bot: I haz the power, 2012-04-07 02:14:18]

Try job failure for 9980015-24001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...