Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: pnacl/build.sh

Issue 9979025: [MIPS] Adding validator for MIPS architecture. (Closed) Base URL: http://src.chromium.org/native_client/trunk/src/native_client/
Patch Set: Minor style changes. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pnacl/build.sh
diff --git a/pnacl/build.sh b/pnacl/build.sh
index 3ac2a91253e5e2a3d9deb7c161ed8c9b0904bb8d..2355aacfcbf469139fa0c58175429b76109d9e98 100755
--- a/pnacl/build.sh
+++ b/pnacl/build.sh
@@ -1822,6 +1822,21 @@ arm-ncval-core ${INSTALL_ROOT}/tools-x86
else
StepBanner "MISC-ARM" "Skipping ARM validator (Not yet supported on Mac)"
fi
+
+ if ${BUILD_PLATFORM_LINUX} ; then
+ StepBanner "MISC-MIPS" "Building validator (MIPS32)"
+ spushd "${NACL_ROOT}"
+ RunWithLog mips_ncval_core \
+ ./scons MODE=opt-host \
+ targetplatform=mips32 \
+ sysinfo=0 \
+ mips-ncval-core
+ cp scons-out/opt-linux-x86-32-to-mips32/obj/src/trusted/validator_mips/\
Brad Chen 2012/05/04 20:16:11 ${SCONS-OUT}, as in the clause above for ARM? Also
robertm 2012/05/04 20:52:44 I think it would be good to factor the code into a
petarj 2012/05/08 14:54:19 Ok, we will refactor it this way.
+mips-ncval-core ${INSTALL_ROOT}/tools-x86/mips-ncval-core
+ spopd
+ else
+ StepBanner "MISC-MIPS" "Skipping MIPS validator (Not yet supported on Mac)"
+ fi
}
#########################################################################

Powered by Google App Engine
This is Rietveld 408576698