chrome/browser/sync/profile_sync_service_bookmark_unittest.cc - Issue 9978017: [Sync] - Upload the callstacks for errors so that the line number of error is in callstack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

Issue 9978017: [Sync] - Upload the callstacks for errors so that the line number of error is in callstack. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: For review. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/glue/session_model_associator.cc ('K') | « chrome/browser/sync/profile_sync_components_factory_impl.cc ('k') | chrome/browser/sync/profile_sync_service_password_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

index 76aebc34ff15d13fb87577489e19e372cc4fe11d..8656d64ec85ffdfcf8e4ec44fa513a68b6dd7cf0 100644

--- a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

@@ -360,8 +360,8 @@ class ProfileSyncServiceBookmarkTest : public testing::Test {

profile_.GetBookmarkModel(),

test_user_share_.user_share(),

&mock_error_handler_));

- SyncError error;

- EXPECT_TRUE(model_associator_->AssociateModels(&error));

+ SyncError error = model_associator_->AssociateModels();

+ EXPECT_FALSE(error.IsSet());

MessageLoop::current()->RunAllPending();

// Set up change processor.

@@ -374,8 +374,8 @@ class ProfileSyncServiceBookmarkTest : public testing::Test {

void StopSync() {

change_processor_->Stop();

change_processor_.reset();

- SyncError error;

- EXPECT_TRUE(model_associator_->DisassociateModels(&error));

+ SyncError error = model_associator_->DisassociateModels();

+ EXPECT_FALSE(error.IsSet());

model_associator_.reset();

message_loop_.RunAllPending();