chrome/browser/sync/glue/password_change_processor.cc - Issue 9978017: [Sync] - Upload the callstacks for errors so that the line number of error is in callstack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/password_change_processor.cc

Issue 9978017: [Sync] - Upload the callstacks for errors so that the line number of error is in callstack. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: For review. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc ('K') | « chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc ('k') | chrome/browser/sync/glue/password_model_associator.h » ('j') | chrome/browser/sync/glue/session_change_processor.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/password_change_processor.cc

diff --git a/chrome/browser/sync/glue/password_change_processor.cc b/chrome/browser/sync/glue/password_change_processor.cc

index 747c55910a92c0106289f17ebc465236491d8fb8..f182fb131cd64d921af9f48b07ac980ee27077e1 100644

--- a/chrome/browser/sync/glue/password_change_processor.cc

+++ b/chrome/browser/sync/glue/password_change_processor.cc

@@ -221,9 +221,11 @@ void PasswordChangeProcessor::CommitChangesFromSyncModel() {

return;

ScopedStopObserving<PasswordChangeProcessor> stop_observing(this);

- if (!model_associator_->WriteToPasswordStore(&new_passwords_,

- &updated_passwords_,

- &deleted_passwords_)) {

+ SyncError error = model_associator_->WriteToPasswordStore(

+ &new_passwords_,

+ &updated_passwords_,

+ &deleted_passwords_);

+ if (error.IsSet()) {

error_handler()->OnSingleDatatypeUnrecoverableError(FROM_HERE,

"Error writing passwords");

return;