[Sync] - Upload the callstacks for errors so that the line number of error is in callstack.

chrome/browser/sync/glue/data_type_controller.cc

Index: chrome/browser/sync/glue/data_type_controller.cc
diff --git a/chrome/browser/sync/glue/data_type_controller.cc b/chrome/browser/sync/glue/data_type_controller.cc
index 0eb5ec6f343ab7ef689178ede0145576d11abb1f..9014ece073505d048dc423f2c6edeb8520448256 100644
--- a/chrome/browser/sync/glue/data_type_controller.cc
+++ b/chrome/browser/sync/glue/data_type_controller.cc
@@ -10,7 +10,7 @@
 namespace browser_sync {
 
 bool DataTypeController::IsUnrecoverableResult(StartResult result) {
-  return (result == ASSOCIATION_FAILED || result == UNRECOVERABLE_ERROR);
+  return (result == UNRECOVERABLE_ERROR);
 }
 
 void DataTypeController::RecordUnrecoverableError(
@@ -25,4 +25,12 @@ void DataTypeController::RecordUnrecoverableError(
   ChromeReportUnrecoverableError();

[Nicolas Zea, 2012/04/05 22:08:58]

This probably needs to be removed now. We'll be uploading an error when a
SyncError is made, and then calling RecordUnrecoverableError either form
OnSingleDatatype or from the DTC's Associate method.

[lipalani1, 2012/04/05 22:51:03]

This is needed in the interim. We will remove it in the next patch (Good eye
btw!) Eventually this method will take SyncError as its only param and do only
UMA reporting. Here is the reason:
we have 4 cases:
Legacy model association: If model association failed then we return
ASSOCIATION_FAILED and for that we will not call RecordUnrecoverableError. We
will only call if it is an unrecoverable error. Look at StartFailed in
NonFrontendDTC and frontendDTC. No UMA will also be reported because of this
change but we will fix that in the next CL. The next CL would simply make this
method take SyncError as a param and will only record the UMA.
Legacy ChangeProcessor: They all simply call OnSingleDatatypeUnrecoverableError
presently which will keep uploading. We will change this method to take in a
SyncError in the next patch and the datatypes would have to call
CreateAndUploadError before calling OnSingleDatatypeUnreocverableError. 
New model associators (mergedataandstartsyncing): We will temporarily not upload
any errors to breakpad(look at StartFailed). But we will fix it in the next cl
when we make them take the interface we spoke about.
New Change processors(part of syncable service) : They presently call
OnSingleDatatypeunrecoverableError which will upload. In the future we will make
them create the error before calling that method.

In Short the new StartFailed would look like the following:
if (error.IsSet()) RecordUnrecoverableError(error);
...(the same code as we have today)

let me know if you have concerns.
On 2012/04/05 22:08:58, nzea wrote:

[Nicolas Zea, 2012/04/06 19:49:47]

Sounds good. Could you add a TODO mentioning that this needs to be removed (here
and in the OnSingleDatatypeUnrecoverable).

 }
 
+SyncError DataTypeController::CreateAndUploadError(
+    const tracked_objects::Location& location,
+    const std::string& message,
+    syncable::ModelType type) {
+  ChromeReportUnrecoverableError();
+  return SyncError(location, message, type);
 }
+
+}  // namespace browser_sync