chrome/browser/sync/profile_sync_components_factory_impl.cc - Issue 9978017: [Sync] - Upload the callstacks for errors so that the line number of error is in callstack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl.cc

Issue 9978017: [Sync] - Upload the callstacks for errors so that the line number of error is in callstack. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/typed_url_model_associator_unittest.cc ('k') | chrome/browser/sync/profile_sync_service_bookmark_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_components_factory_impl.cc

diff --git a/chrome/browser/sync/profile_sync_components_factory_impl.cc b/chrome/browser/sync/profile_sync_components_factory_impl.cc

index 3d45609b036b21063b86a9cccaecc10076d0671b..e3e182df5a4eb16292b265483a5d938187e74fcb 100644

--- a/chrome/browser/sync/profile_sync_components_factory_impl.cc

+++ b/chrome/browser/sync/profile_sync_components_factory_impl.cc

@@ -292,7 +292,8 @@ ProfileSyncComponentsFactory::SyncComponents

DataTypeErrorHandler* error_handler) {

PasswordModelAssociator* model_associator =

new PasswordModelAssociator(profile_sync_service,

- password_store);

+ password_store,

+ error_handler);

PasswordChangeProcessor* change_processor =

new PasswordChangeProcessor(model_associator,

password_store,

@@ -306,7 +307,7 @@ ProfileSyncComponentsFactory::SyncComponents

ProfileSyncService* profile_sync_service,

DataTypeErrorHandler* error_handler) {

ThemeModelAssociator* model_associator =

- new ThemeModelAssociator(profile_sync_service);

+ new ThemeModelAssociator(profile_sync_service, error_handler);

ThemeChangeProcessor* change_processor =

new ThemeChangeProcessor(error_handler);

return SyncComponents(model_associator, change_processor);

@@ -320,7 +321,8 @@ ProfileSyncComponentsFactory::SyncComponents

browser_sync::DataTypeErrorHandler* error_handler) {

TypedUrlModelAssociator* model_associator =

new TypedUrlModelAssociator(profile_sync_service,

- history_backend);

+ history_backend,

+ error_handler);

TypedUrlChangeProcessor* change_processor =

new TypedUrlChangeProcessor(profile_,

model_associator,

@@ -334,7 +336,7 @@ ProfileSyncComponentsFactory::SyncComponents

ProfileSyncService* profile_sync_service,

DataTypeErrorHandler* error_handler) {

SessionModelAssociator* model_associator =

- new SessionModelAssociator(profile_sync_service);

+ new SessionModelAssociator(profile_sync_service, error_handler);

SessionChangeProcessor* change_processor =

new SessionChangeProcessor(error_handler, model_associator);

return SyncComponents(model_associator, change_processor);