[Sync] - Upload the callstacks for errors so that the line number of error is in callstack.

chrome/browser/sync/glue/session_change_processor.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/session_change_processor.h"
 
 #include <string>
 #include <vector>
 
 #include "base/logging.h"
@@ skipping 196 matching lines @@
           chrome::NOTIFICATION_SYNC_REFRESH,
           content::Source<Profile>(profile_),
           content::Details<const syncable::ModelType>(&type));
     }
   }
 
   // Associate tabs first so the synced session tracker is aware of them.
   // Note that if we fail to associate, it means something has gone wrong,
   // such as our local session being deleted, so we disassociate and associate
   // again.
-  SyncError error;
   bool reassociation_needed = !modified_tabs.empty() &&
-      !session_model_associator_->AssociateTabs(modified_tabs, &error);
+      !session_model_associator_->AssociateTabs(modified_tabs, NULL);
 
   // Note, we always associate windows because it's possible a tab became
   // "interesting" by going to a valid URL, in which case it needs to be added
   // to the window's tab information.
   if (!reassociation_needed) {
     reassociation_needed =
-        !session_model_associator_->AssociateWindows(false, &error);
+        !session_model_associator_->AssociateWindows(false, NULL);
   }
 
   if (reassociation_needed) {
     LOG(WARNING) << "Reassociation of local models triggered.";
     // Needing to reassociate would have set the error already so clear it.

[Nicolas Zea, 2012/04/05 22:08:58]

remove comment.

[lipalani1, 2012/04/05 22:51:03]

Done.

-    error = SyncError();
-    session_model_associator_->DisassociateModels(&error);
-    session_model_associator_->AssociateModels(&error);
+    SyncError error;
+    error = session_model_associator_->DisassociateModels();
+    error = session_model_associator_->AssociateModels();
     if (error.IsSet()) {
       error_handler()->OnSingleDatatypeUnrecoverableError(FROM_HERE,
           "Sessions reassociation failed.");
     }
   }
 }
 
 void SessionChangeProcessor::ApplyChangesFromSyncModel(
     const sync_api::BaseTransaction* trans,
     const sync_api::ImmutableChangeRecordList& changes) {
@@ skipping 107 matching lines @@
       content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,
       content::NotificationService::AllBrowserContextsAndSources());
 }
 
 void SessionChangeProcessor::StopObserving() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   notification_registrar_.RemoveAll();
 }
 
 }  // namespace browser_sync