content/browser/speech/google_one_shot_remote_engine.h - Issue 9972011: Speech refactoring: Reimplemented SpeechRecognitionManagerImpl as a FSM. (CL1.7)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/google_one_shot_remote_engine.h

Issue 9972011: Speech refactoring: Reimplemented SpeechRecognitionManagerImpl as a FSM. (CL1.7) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed according to Satish review. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc ('K') | « chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc ('k') | content/browser/speech/google_one_shot_remote_engine.cc » ('j') | content/browser/speech/input_tag_speech_dispatcher_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/speech/google_one_shot_remote_engine.h

diff --git a/content/browser/speech/google_one_shot_remote_engine.h b/content/browser/speech/google_one_shot_remote_engine.h

index 7e47c67dd68b4c323d21337662b595d6a507beba..a3ac48ca75303eee7edaa8aa0be3c7c4f351845e 100644

--- a/content/browser/speech/google_one_shot_remote_engine.h

+++ b/content/browser/speech/google_one_shot_remote_engine.h

@@ -75,6 +75,7 @@ class CONTENT_EXPORT GoogleOneShotRemoteEngine

scoped_ptr<content::URLFetcher> url_fetcher_;

scoped_refptr<net::URLRequestContextGetter> url_context_;

scoped_ptr<AudioEncoder> encoder_;

+ bool url_fetcher_destroyed_;

Satish 2012/04/23 10:25:17 Should these changes be removed?

Primiano Tucci (use gerrit) 2012/04/23 12:52:25 I did remove them in the last patch-set. Probably

DISALLOW_COPY_AND_ASSIGN(GoogleOneShotRemoteEngine);

};