Speech refactoring: Reimplemented SpeechRecognitionManagerImpl as a FSM. (CL1.7)

chrome/browser/speech/chrome_speech_recognition_manager_delegate.h

Index: chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
diff --git a/chrome/browser/speech/chrome_speech_recognition_manager_delegate.h b/chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
index d209852f5cc759f55774d2b1c357faec171c6617..dbb9ad3fcd43aa6295ef7b3632cdcffe524ff148 100644
--- a/chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
+++ b/chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
@@ -10,6 +10,10 @@
 #include "chrome/browser/speech/speech_recognition_bubble_controller.h"
 #include "content/public/browser/speech_recognition_manager_delegate.h"
 
+namespace base {
+class WaitableEvent;
+}
+
 namespace speech {
 
 // This is Chrome's implementation of the SpeechRecognitionManager interface.
@@ -28,27 +32,26 @@ class ChromeSpeechRecognitionManagerDelegate
 
  protected:
   // SpeechRecognitionManagerDelegate methods.
-  virtual void GetRequestInfo(bool* can_report_metrics,
-                              std::string* request_info) OVERRIDE;
-  virtual void ShowRecognitionRequested(int session_id,
-                                        int render_process_id,
-                                        int render_view_id,
-                                        const gfx::Rect& element_rect) OVERRIDE;
+  virtual void GetDiagnosticInformation(bool* can_report_metrics,
+                                        std::string* hardware_info) OVERRIDE;
+  virtual bool IsRecognitionAllowed(int session_id) OVERRIDE;
+  virtual void ShowRecognitionRequested(int session_id) OVERRIDE;
   virtual void ShowWarmUp(int session_id) OVERRIDE;
   virtual void ShowRecognizing(int session_id) OVERRIDE;
   virtual void ShowRecording(int session_id) OVERRIDE;
   virtual void ShowInputVolume(int session_id,
                                float volume,
                                float noise_volume) OVERRIDE;
-  virtual void ShowMicError(int session_id,
-                            MicError error) OVERRIDE;
-  virtual void ShowRecognizerError(
-      int session_id, content::SpeechRecognitionErrorCode error) OVERRIDE;
+  virtual void ShowError(int session_id,
+                         const content::SpeechRecognitionError& error) OVERRIDE;
   virtual void DoClose(int session_id) OVERRIDE;
 
  private:
   class OptionalRequestInfo;
 
+  static void CheckRenderViewType(int render_process_id, int render_view_id,

[Satish, 2012/04/23 10:25:17]

Use a single parameter per line for such long declarations

[Primiano Tucci (use gerrit), 2012/04/23 12:52:25]

Done.

+                                  bool* result, base::WaitableEvent* event);
+
   scoped_refptr<SpeechRecognitionBubbleController> bubble_controller_;
   scoped_refptr<OptionalRequestInfo> optional_request_info_;