Speech refactoring: Reimplemented SpeechRecognitionManagerImpl as a FSM. (CL1.7)

content/public/browser/speech_recognition_session_context.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_SPEECH_RECOGNITION_SESSION_CONTEXT_H_
+#define CONTENT_PUBLIC_BROWSER_SPEECH_RECOGNITION_SESSION_CONTEXT_H_
+
+#include "content/common/content_export.h"
+#include "ui/gfx/rect.h"
+
+namespace content {
+
+// The context information required by clients of the SpeechRecognitionManager
+// (InputTagSpeechDispatcherHost) and its delegates
+// (ChromeSpeechRecognitionManagerDelegate) for mapping the recognition session

[jam, 2012/04/24 15:56:32]

nit: don't mention chrome classes in the public api for content

[Primiano Tucci (use gerrit), 2012/04/25 11:30:03]

Done.

+// to other browser elements involved with the it (e.g., the page element that
+// requested the recognition, the UI bubbles). The SpeechRecognitionManager is
+// not aware of the content of this struct and does NOT use it for its purposes.
+// However the manager keeps this struct "attached" to the recognition session
+// during all the session lifetime, making its contents available to clients
+// (In this regard, see SpeechRecognitionManager::GetSessionContext and
+// SpeechRecognitionManager::LookupSessionByContext methods).
+struct CONTENT_EXPORT SpeechRecognitionSessionContext {

[jam, 2012/04/24 15:56:32]

nit: are you sure you need a CONTENT_EXPORT for this? and also are you usre you
need a cc file?

[Primiano Tucci (use gerrit), 2012/04/25 11:30:03]

It is used by tests (speech_recognition_browsertest.cc) and,  IIRC, without it
fails compilation on win bots.
Uhm, seems not. I just realized that the "complex class/struct" error is based
on a score system, not just the presence of non POD fields.

+  SpeechRecognitionSessionContext();
+  ~SpeechRecognitionSessionContext();
+
+  int render_process_id;
+  int render_view_id;
+  int render_request_id;
+  gfx::Rect element_rect;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_BROWSER_SPEECH_RECOGNITION_SESSION_CONTEXT_H_