Issue 9969204: Removed obsolete parameter from file_manager_util::ViewFile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9969204: Removed obsolete parameter from file_manager_util::ViewFile (Closed)

Created:
8 years, 8 months ago by Vladislav Kaznacheev

Modified:
8 years, 8 months ago

Reviewers:
Nikita (slow), dgozman, nkostylev (pls use chromium)

CC:
chromium-reviews, asanka, nkostylev+watch_chromium.org, achuith+watch_chromium.org, mihaip+watch_chromium.org, Randy Smith (Not in Mondays), Aaron Boodman, rginda+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removed obsolete parameter from file_manager_util::ViewFile BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132581

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -6 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager_util.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/platform_util_chromeos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/active_downloads_ui.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

Please review this small patch. Nikita, your approval is needed for chrome/browser/ui/webui/chromeos/active_downloads_ui.cc Thanks, Vlad

8 years, 8 months ago (2012-04-17 13:18:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/9969204/1

8 years, 8 months ago (2012-04-17 14:27:57 UTC) #4

Change committed as 132581

Expand Messages | Collapse Messages