Add method flush to output stream

runtime/bin/file_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class _FileInputStream extends _BaseDataInputStream implements InputStream {
   _FileInputStream(String name) {
     _file = new File(name);
     _data = [];
     _position = 0;
     _file.onError = (e) {
@@ skipping 73 matching lines @@
     _closed = true;
   }
 
   File _file;
   List<int> _data;
   int _position;
   bool _closed = false;
 }
 
 
+class _PendingOperation {
+  const _PendingOperation();
+  static final _PendingOperation CLOSE = const _PendingOperation();
+  static final _PendingOperation FLUSH = const _PendingOperation();
+}
+
+
 class _FileOutputStream extends _BaseOutputStream implements OutputStream {
   _FileOutputStream(String name, FileMode mode) {
-    _pendingOperations = new List<List<int>>();
+    _pendingOperations = new List();
     var f = new File(name);
     f.open(mode, (openedFile) {
       _file = openedFile;
       _setupFileHandlers();
       _processPendingOperations();
     });
     f.onError = (e) {
       if (_onError != null) _onError(e);
     };
   }
@@ skipping 36 matching lines @@
     var length = buffer.length - offset;
     if (len != null) {
       if (len > length) throw new IndexOutOfRangeException(len);
       length = len;
     }
     var copy = new ByteArray(length);
     copy.setRange(0, length, buffer, offset);
     return write(copy);
   }
 
+  void flush() {
+    if (_file == null) {
+      _pendingOperations.add(_PendingOperation.FLUSH);
+    } else {
+      _file.flush();

[Mads Ager (google), 2012/04/17 11:56:44]

Isn't _file a RandomAccessFile? Doesn't flush take a callback argument?

[Søren Gjesse, 2012/04/17 13:14:19]

It does - not sure why no tests failed.

Turend out my _PendingOperation sentinels where not different, and there was no
onError handler in the test.

+    }
+  }
+
   void close() {
     if (_file == null) {
-      _pendingOperations.add(null);
+      _pendingOperations.add(_PendingOperation.CLOSE);
     } else if (!_streamMarkedClosed) {
       _file.close(() {
         if (_onClosed != null) _onClosed();
       });
       _streamMarkedClosed = true;
     }
   }
 
   void set onNoPendingWrites(void callback()) {
     _onNoPendingWrites = callback;
   }
 
   void set onClosed(void callback()) {
     _onClosed = callback;
   }
 
   void set onError(void callback(Exception e)) {
     _onError = callback;
   }
 
   void _processPendingOperations() {
     _pendingOperations.forEach((buffer) {
-      (buffer != null) ? write(buffer) : close();
+        if (buffer is _PendingOperation) {
+          if (buffer === _PendingOperation.CLOSE) {
+            close();
+          } else {
+            assert(buffer === _PendingOperation.FLUSH);
+            flush();
+          }
+        } else {
+          write(buffer);
+        }
     });
     _pendingOperations = null;
   }
 
   void _write(List<int> buffer, int offset, int len) {
     _file.writeList(buffer, offset, len);
   }
 
   RandomAccessFile _file;
 
   // When this is set to true the stream is marked closed. When a
   // stream is marked closed no more data can be written.
   bool _streamMarkedClosed = false;
 
   // When this is set to true the close callback has been called and
   // the stream is fully closed.
   bool _closeCallbackCalled = false;
 
   // List of pending writes that were issued before the underlying
   // file was successfully opened.
-  List<List<int>> _pendingOperations;
+  List _pendingOperations;
 
   Function _onNoPendingWrites;
   Function _onClosed;
   Function _onError;
 }
 
 
 // Helper class containing static file helper methods.
 class _FileUtils {
   static final kExistsRequest = 0;
@@ skipping 849 matching lines @@
   String _name;
   int _id;
   int _pendingWrites = 0;
 
   SendPort _fileService;
 
   Timer _noPendingWriteTimer;
 
   Function _onNoPendingWrites;
 }