Fix removal of delegate execute registration at uninstall.

Fix removal of delegate execute registration at uninstall.

BUG=119242
TEST=install Chrome, uninstall Chrome, make sure delegate execute stuff goes away.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132495

[grt (UTC plus 2), 2012-04-16 21:08:09]

some days i'm worse than others

[robertshield, 2012-04-16 22:41:30]

lgtm

[commit-bot: I haz the power, 2012-04-16 22:52:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/9969186/1

[gab, 2012-04-17 00:11:04]

I just thought of something related to this.

In the build I had that made me notice this missing uninstall I had an
interesting thing happen to me where I made a user-level install, uninstalled
it, made a system-level install, and then the registrations from the user-level
(which weren't uninstalled because of the bug fixed by this CL) had priority
over the registrations from the system-level install (but the user-level install
no longer existing, I couldn't launch Chrome from the shortcut).

When we install at system-level do we perform a full uninstall of the user-level
chromes present to avoid these kind of problems?

[commit-bot: I haz the power, 2012-04-17 00:39:29]

Change committed as 132495

[grt (UTC plus 2), 2012-04-17 00:56:54]

On 2012/04/17 00:11:04, gab wrote:
> I just thought of something related to this.
> 
> In the build I had that made me notice this missing uninstall I had an
> interesting thing happen to me where I made a user-level install, uninstalled
> it, made a system-level install, and then the registrations from the
user-level
> (which weren't uninstalled because of the bug fixed by this CL) had priority
> over the registrations from the system-level install (but the user-level
install
> no longer existing, I couldn't launch Chrome from the shortcut).
> 
> When we install at system-level do we perform a full uninstall of the
user-level
> chromes present to avoid these kind of problems?

Good question.  The user-level Chrome will invoke its own uninstaller when it's
launched following the installation of system-level Chrome
(http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/chrome_brow...).
 This will hit the code to remove the COM registration for the delegate from
HKCU.

One thing to test, though, is the impact of this on Win8 default browserness. 
If the user-level Chrome has the special "default browser" status, it'll lose
that when it self-destructs.  I wonder what the behavior is on Win8 for the
following:

1. Install user-level Chrome and make it the default browser.
2. Install system-level Chrome (as SYSTEM or as another user)
3. Launch user-level Chrome.

Does Win8 automatically pop up the browser selection dialog?  Does IE become the
default again automatically?