Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 9969185: third_party/libusb: vs2010 build fixes and android-conditional build (Closed)

Created:
8 years, 8 months ago by Garret Kelly
Modified:
8 years, 8 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Visibility:
Public.

Description

third_party/libusb: vs2010 build fixes and android-conditional build This patch fixes the libusb vs2010 build break as reported by a few people, as well as makes the libusb build conditional on not being on the Android platform. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M chrome/chrome_browser.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/libusb/libusb.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/libusb/libusb/os/windows_usb.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/libusb/windows-build.patch View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Garret Kelly
8 years, 8 months ago (2012-04-16 20:51:24 UTC) #1
sadrul
LGTM (rubber-stamp)
8 years, 8 months ago (2012-04-16 20:53:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gdk@chromium.org/9969185/1
8 years, 8 months ago (2012-04-17 15:17:10 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 17:38:43 UTC) #4
Change committed as 132595

Powered by Google App Engine
This is Rietveld 408576698