Ignoring alignment when it pushes a window out of the screen

ash/wm/workspace/workspace_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/workspace/workspace_manager.h"
 
 #include <algorithm>
 
 #include "ash/screen_ash.h"
 #include "ash/shell.h"
@@ skipping 32 matching lines @@
 // Returns a list of all the windows with layers in |result|.
 void BuildWindowList(const std::vector<aura::Window*>& windows,
                      std::vector<aura::Window*>* result) {
   for (size_t i = 0; i < windows.size(); ++i) {
     if (windows[i]->layer())
       result->push_back(windows[i]);
     BuildWindowList(windows[i]->transient_children(), result);
   }
 }
 
 gfx::Rect AlignRectToGrid(const gfx::Rect& rect, int grid_size) {

[sky, 2012/04/11 21:10:00]

I believe this is called from a handful of places, and I'm not sure we would
always want to ignore the grid. Who is configuring the bounds that is triggering
this bug?

   if (grid_size <= 1)
     return rect;
-  return gfx::Rect(ash::WindowResizer::AlignToGrid(rect.x(), grid_size),
-                   ash::WindowResizer::AlignToGrid(rect.y(), grid_size),
-                   ash::WindowResizer::AlignToGrid(rect.width(), grid_size),
-                   ash::WindowResizer::AlignToGrid(rect.height(), grid_size));
+  int x = ash::WindowResizer::AlignToGrid(rect.x(), grid_size);
+  int y = ash::WindowResizer::AlignToGrid(rect.y(), grid_size);
+  int w = ash::WindowResizer::AlignToGrid(rect.width(), grid_size);
+  int h = ash::WindowResizer::AlignToGrid(rect.height(), grid_size);
+
+  // If the alignment was pushing the window out of the screen, we ignore the
+  // alignment for that call.
+  const gfx::Rect work_area =
+      gfx::Screen::GetMonitorWorkAreaNearestPoint(
+          gfx::Point((rect.x() + rect.width()) / 2,
+                     (rect.y() + rect.height()) / 2));
+
+  if (rect.x() + rect.width() <= work_area.width() &&
+      x + w > work_area.width()) {
+    x = rect.x();

[sky, 2012/04/11 21:10:00]

Why ignore the grid in this case?

+    w = rect.width();
+  }
+  if (rect.y() + rect.height() <= work_area.height() &&
+      y + h > work_area.height()) {
+    y = rect.y();
+    h = rect.height();
+  }
+
+  return gfx::Rect(x, y, w, h);
 }
 
 }
 
 namespace ash {
 namespace internal {
 
 ////////////////////////////////////////////////////////////////////////////////
 // WindowManager, public:
 
@@ skipping 290 matching lines @@
   return workspace;
 }
 
 void WorkspaceManager::CleanupWorkspace(Workspace* workspace) {
   if (workspace->type() != Workspace::TYPE_MANAGED && workspace->is_empty())
     delete workspace;
 }
 
 }  // namespace internal
 }  // namespace ash