Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 9969110: mac: Tell Panel.xib that PanelWindowCocoaImpl derives from NSWindow. (Closed)

Created:
8 years, 8 months ago by Nico
Modified:
8 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Visibility:
Public.

Description

mac: Tell Panel.xib that PanelWindowCocoaImpl derives from NSWindow. xib changes: Added "NSWindow" to the inheritance field of PanelWindowCocoaImpl. BUG=121704 TEST=2 fewer build warnings, no behavior change NOTRY=true closed in favor of r130457

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chrome/app/nibs/Panel.xib View 4 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nico
8 years, 8 months ago (2012-04-03 17:28:16 UTC) #1
Nico
The real inheritance chain is PWCI <- ChromeBrowserWindow <- ChromeEventProcessingWindow <- NSWindow. Is it better ...
8 years, 8 months ago (2012-04-03 17:30:21 UTC) #2
Robert Sesek
lgtm
8 years, 8 months ago (2012-04-03 17:49:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9969110/1
8 years, 8 months ago (2012-04-03 18:06:28 UTC) #4
commit-bot: I haz the power
Try job failure for 9969110-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-03 18:45:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9969110/1
8 years, 8 months ago (2012-04-03 18:48:11 UTC) #6
commit-bot: I haz the power
Try job failure for 9969110-1 (previous was lost) (retry) on win_rel for steps "browser_tests, unit_tests". ...
8 years, 8 months ago (2012-04-03 23:27:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9969110/1
8 years, 8 months ago (2012-04-04 00:33:49 UTC) #8
commit-bot: I haz the power
8 years, 8 months ago (2012-04-04 00:33:50 UTC) #9
Can't apply patch for file chrome/app/nibs/Panel.xib.
While running patch -p1 --forward --force;
patching file chrome/app/nibs/Panel.xib
Hunk #1 FAILED at 12.
Hunk #4 succeeded at 700 with fuzz 1 (offset 24 lines).
1 out of 4 hunks FAILED -- saving rejects to file chrome/app/nibs/Panel.xib.rej

Powered by Google App Engine
This is Rietveld 408576698