Allow overriding base-url in git-cl.

Allow overriding base-url in git-cl.

This is useful if git-cl has no way to find out the original svn repo's url
and the user does not wish to configure git-svn and fetch the repository.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130372

[M-A Ruel, 2012-04-03 15:18:40]

I'm a bit ambivalent as I wanted to move all the "remote-url" logic into a
git-utils/git-remote-url script, that git-cl would simply shell out. So this
code would make sense to be moved there too. But I don't want to block you so
lgtm, but please upload a patchset with the following changes done first.

http://codereview.chromium.org/9969099/diff/1/git_cl.py
File git_cl.py (right):

http://codereview.chromium.org/9969099/diff/1/git_cl.py#newcode795
git_cl.py:795: 
2 spaces between file level symbols

http://codereview.chromium.org/9969099/diff/1/git_cl.py#newcode801
git_cl.py:801: if len(args) == 0:
if not args:

http://codereview.chromium.org/9969099/diff/1/git_cl.py#newcode809
git_cl.py:809: 
same

[kalmard, 2012-04-03 15:27:10]

Thanks for the review.

http://codereview.chromium.org/9969099/diff/1/git_cl.py
File git_cl.py (right):

http://codereview.chromium.org/9969099/diff/1/git_cl.py#newcode795
git_cl.py:795: 
On 2012/04/03 15:18:40, Marc-Antoine Ruel wrote:
> 2 spaces between file level symbols

Done.

http://codereview.chromium.org/9969099/diff/1/git_cl.py#newcode801
git_cl.py:801: if len(args) == 0:
On 2012/04/03 15:18:40, Marc-Antoine Ruel wrote:
> if not args:

Done.

http://codereview.chromium.org/9969099/diff/1/git_cl.py#newcode809
git_cl.py:809: 
On 2012/04/03 15:18:40, Marc-Antoine Ruel wrote:
> same

Done.

[M-A Ruel, 2012-04-03 15:29:58]

2 more questions

http://codereview.chromium.org/9969099/diff/2001/git_cl.py
File git_cl.py (right):

http://codereview.chromium.org/9969099/diff/2001/git_cl.py#newcode804
git_cl.py:804: return RunGit(['config', 'branch.%s.base-url' % branch],
Won't this crash if the value is not present?

http://codereview.chromium.org/9969099/diff/2001/git_cl.py#newcode808
git_cl.py:808: return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
Also, isn't this annoying to have this per branch with no default fallback?

[kalmard, 2012-04-03 15:37:41]

http://codereview.chromium.org/9969099/diff/2001/git_cl.py
File git_cl.py (right):

http://codereview.chromium.org/9969099/diff/2001/git_cl.py#newcode804
git_cl.py:804: return RunGit(['config', 'branch.%s.base-url' % branch],
On 2012/04/03 15:29:58, Marc-Antoine Ruel wrote:
> Won't this crash if the value is not present?

It returns a valid error. I don't think that's a problem, as this command is
only called manually.

http://codereview.chromium.org/9969099/diff/2001/git_cl.py#newcode808
git_cl.py:808: return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
On 2012/04/03 15:29:58, Marc-Antoine Ruel wrote:
> Also, isn't this annoying to have this per branch with no default fallback?

I figured it made sense to make this per-branch since most (all?) other git-cl
information is stored per-branch. This can be changed of course if you wish.

As for the default fallback: there are already several fallbacks (svn remote,
git remote, git origin) if this override is not set, but again, I can change
this if you think it's necessary.

[commit-bot: I haz the power, 2012-04-03 15:39:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalmard@homejinni.com/9969099/2001

[commit-bot: I haz the power, 2012-04-03 15:45:09]

Change committed as 130372