chrome/common/extensions/api/extension_api.cc - Issue 9969087: Switch platform apps from a declarative launch container to handling an onLaunched event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_api.cc

Issue 9969087: Switch platform apps from a declarative launch container to handling an onLaunched event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ready for review Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.cc ('K') | « chrome/common/extensions/api/experimental.runtime.json ('k') | chrome/common/extensions/docs/examples/extensions/calculator.zip » ('j') | chrome/common/extensions/docs/examples/extensions/calculator/manifest.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_api.cc

diff --git a/chrome/common/extensions/api/extension_api.cc b/chrome/common/extensions/api/extension_api.cc

index 2615d437844c99dd49dd5af53801a793706df537..2953a35828bb4aeb02eef45a57bb8a1f9d839273 100644

--- a/chrome/common/extensions/api/extension_api.cc

+++ b/chrome/common/extensions/api/extension_api.cc

@@ -62,8 +62,8 @@ scoped_ptr<ListValue> LoadSchemaList(const base::StringPiece& schema) {

false, // allow trailing commas

NULL, // error code

&error_message));

- CHECK(result.get()) << error_message;

- CHECK(result->IsType(Value::TYPE_LIST));

+ CHECK(result.get()) << error_message << " for schema " << schema;

+ CHECK(result->IsType(Value::TYPE_LIST)) << " for schema " << schema;

return scoped_ptr<ListValue>(static_cast<ListValue*>(result.release()));

}