chrome/browser/ui/extensions/shell_window.h - Issue 9969087: Switch platform apps from a declarative launch container to handling an onLaunched event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/shell_window.h

Issue 9969087: Switch platform apps from a declarative launch container to handling an onLaunched event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Mike's review feedback Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm ('k') | chrome/browser/ui/gtk/extensions/shell_window_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/shell_window.h

diff --git a/chrome/browser/ui/extensions/shell_window.h b/chrome/browser/ui/extensions/shell_window.h

index 90cc69202d249ceb196506370432dabf3bf3f0ed..2790b74d1d823f51a22b29135e1fec4eacf0a4e2 100644

--- a/chrome/browser/ui/extensions/shell_window.h

+++ b/chrome/browser/ui/extensions/shell_window.h

@@ -26,6 +26,11 @@ class WebContents;

class ShellWindow : public content::NotificationObserver,

public BaseWindow {

public:

+ // TODO(mihaip): Switch from hardcoded defaults to passing in the window

+ // creation parameters to ShellWindow::Create.

+ static const int kDefaultWidth = 512;

+ static const int kDefaultHeight = 384;

content::WebContents* web_contents() const { return host_->host_contents(); }

const SessionID& session_id() const { return session_id_; }

const ExtensionWindowController* extension_window_controller() const {

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm ('k') | chrome/browser/ui/gtk/extensions/shell_window_gtk.cc » ('j') | no next file with comments »