Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: chrome/browser/extensions/extension_apitest.cc

Issue 9969087: Switch platform apps from a declarative launch container to handling an onLaunched event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Mike's review feedback Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_apitest.cc
diff --git a/chrome/browser/extensions/extension_apitest.cc b/chrome/browser/extensions/extension_apitest.cc
index 27951682f013e13de0a791dfcb16542ddcdfaad9..7e4cf62a5414fc6521d506c7ce7b502f06fdf140 100644
--- a/chrome/browser/extensions/extension_apitest.cc
+++ b/chrome/browser/extensions/extension_apitest.cc
@@ -151,7 +151,7 @@ bool ExtensionApiTest::RunPageTest(const std::string& page_url) {
}
bool ExtensionApiTest::RunPlatformAppTest(const char* extension_name) {
- return RunExtensionTestImpl(extension_name, "", kFlagLaunchAppShell);
+ return RunExtensionTestImpl(extension_name, "", kFlagLaunchPlatformApp);
}
// Load |extension_name| extension and/or |page_url| and wait for
@@ -162,7 +162,7 @@ bool ExtensionApiTest::RunExtensionTestImpl(const char* extension_name,
bool enable_incognito = (flags & kFlagEnableIncognito) != 0;
bool enable_fileaccess = (flags & kFlagEnableFileAccess) != 0;
bool load_as_component = (flags & kFlagLoadAsComponent) != 0;
- bool launch_shell = (flags & kFlagLaunchAppShell) != 0;
+ bool launch_platform_app = (flags & kFlagLaunchPlatformApp) != 0;
bool use_incognito = (flags & kFlagUseIncognito) != 0;
ResultCatcher catcher;
@@ -203,11 +203,11 @@ bool ExtensionApiTest::RunExtensionTestImpl(const char* extension_name,
else
ui_test_utils::NavigateToURL(browser(), url);
- } else if (launch_shell) {
+ } else if (launch_platform_app) {
Browser::OpenApplication(
browser()->profile(),
extension,
- extension_misc::LAUNCH_SHELL,
+ extension_misc::LAUNCH_NONE,
GURL(),
NEW_WINDOW);
}
« no previous file with comments | « chrome/browser/extensions/extension_apitest.h ('k') | chrome/browser/extensions/extension_function_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698