Switch platform apps from a declarative launch container to handling an onLaunched event.

chrome/browser/ui/gtk/extensions/shell_window_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/extensions/shell_window_gtk.h"
 
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "ui/base/x/active_window_watcher_x.h"
 #include "ui/gfx/rect.h"
 
 ShellWindowGtk::ShellWindowGtk(ExtensionHost* host)
     : ShellWindow(host),
       state_(GDK_WINDOW_STATE_WITHDRAWN),
       is_active_(!ui::ActiveWindowWatcherX::WMSupportsActivation()) {
   host_->view()->SetContainer(this);
   window_ = GTK_WINDOW(gtk_window_new(GTK_WINDOW_TOPLEVEL));
 
   gtk_container_add(GTK_CONTAINER(window_), host_->view()->native_view());
 
+  gtk_window_set_default_size(window_, 512, 384);

[miket_OOO, 2012/04/06 18:05:01]

If these values are temporary, fine. But since I see them in more than one
place, would it make sense to give them constant names rather than using
immediate values?

[Mihai Parparita -not on Chrome, 2012/04/06 22:02:59]

Moved to shared constants (defined in shell_window.h)

+
   const Extension* extension = host_->extension();
 
-  // TOOD(mihaip): restore prior window dimensions and positions on relaunch.
-  gtk_window_set_default_size(
-      window_, extension->launch_width(), extension->launch_height());
-
-  int min_width = extension->launch_min_width();
-  int min_height = extension->launch_min_height();
-  int max_width = extension->launch_max_width();
-  int max_height = extension->launch_max_height();
-  GdkGeometry hints;
-  int hints_mask = 0;
-  if (min_width || min_height) {
-    hints.min_height = min_height;
-    hints.min_width = min_width;
-    hints_mask |= GDK_HINT_MIN_SIZE;
-  }
-  if (max_width || max_height) {
-    hints.max_height = max_height ? max_height : G_MAXINT;
-    hints.max_width = max_width ? max_width : G_MAXINT;
-    hints_mask |= GDK_HINT_MAX_SIZE;
-  }
-  if (hints_mask) {
-    gtk_window_set_geometry_hints(
-        window_,
-        GTK_WIDGET(window_),
-        &hints,
-        static_cast<GdkWindowHints>(hints_mask));
-  }
-
   // TODO(mihaip): Mirror contents of <title> tag in window title
   gtk_window_set_title(window_, extension->name().c_str());
 
   g_signal_connect(window_, "delete-event",
                    G_CALLBACK(OnMainWindowDeleteEventThunk), this);
   g_signal_connect(window_, "configure-event",
                    G_CALLBACK(OnConfigureThunk), this);
   g_signal_connect(window_, "window-state-event",
                    G_CALLBACK(OnWindowStateThunk), this);
 
@@ skipping 120 matching lines @@
 gboolean ShellWindowGtk::OnWindowState(GtkWidget* sender,
                                        GdkEventWindowState* event) {
   state_ = event->new_window_state;
   return FALSE;
 }
 
 // static
 ShellWindow* ShellWindow::CreateShellWindow(ExtensionHost* host) {
   return new ShellWindowGtk(host);
 }